[mypyc] Enable assertions in tests and fix failures#20553
Merged
Conversation
JukkaL
approved these changes
Jan 9, 2026
Collaborator
|
Btw, could be good to get the tests running against a debug build again: mypy/.github/workflows/test.yml Lines 94 to 102 in 458cfe1 Due to a test misconfiguration the test was previously not running against a debug build and it unfortunately looks like it is broken, see the issues linked in the comment^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason assertions are disabled when running mypyc tests. Explicitly undefining
NDEBUGwhen compiling enables them again so I have added compiler options to undefine it when requested optimization level is 0.Found two issues after enabling them:
Py_SIZEhas an assertion to disallow calling it withPyLongarguments starting from python 3.12. Compiled code would call it when convertingPyLongtoint64. Instead we can usePyUnstable_Long_CompactValue.